Use Deref in objc2-foundation and remove "INS" helper traits
#115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
force-pushed
the
foundation-deref
branch
7 times, most recently
from
797a5b0 to
5980596
Compare
madsmtm
force-pushed
the
foundation-deref
branch
from
5980596 to
11ccf00
Compare
|
I'm probably just gonna go and merge this, though we need a better solution for specifying a bound that says "this is an object, and not just something that is messageable" (see also #66). |
madsmtm
changed the title
Deref in objc2-foundationDeref in objc2-foundation and remove "INS" helper traits
madsmtm
force-pushed
the
foundation-deref
branch
from
44e0f2d to
9e11572
Compare
This assertion failed in CI GNUStep 32bit with the retain count being 2 instead of the expected 1. If I see this issue again, I'll try to investigate it
madsmtm
force-pushed
the
foundation-deref
branch
from
fa35d4b to
2029dc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Huge part of #58.
Also renamed protocols, now that the possible confusion from them is gone.
(Yes, there exists both the
NSObjectclass and theNSObjectprotocol, but that is something we'll paper over).