Skip to content

Can't upload image for custom customer address attribute #39720 #39791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

ajay2108
Copy link

@ajay2108 ajay2108 commented Apr 7, 2025

Description (*)

This pull request fixes an issue where a custom customer address attribute with a frontend input type of "image" could not accept image uploads. When trying to save a customer address with an image uploaded for the custom attribute, an error message was displayed: "xxx.jpeg is not a valid file."

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Can't upload image for custom customer address attribute #39720

Manual testing scenarios (*)

  1. Create a custom customer address attribute with frontend_input="image".
  2. Go to the customer edit page in the admin panel.
  3. Attempt to upload an image for the custom address attribute.
  4. Observe the error message "xxx.jpeg is not a valid file" when trying to save the address.
  5. You will see no error appears and address gets saved successfully.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Apr 7, 2025

Hi @ajay2108. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@ajay2108
Copy link
Author

ajay2108 commented Apr 7, 2025

@magento run all tests

@ajay2108
Copy link
Author

ajay2108 commented Apr 8, 2025

@magento run Static Tests

@ajay2108
Copy link
Author

ajay2108 commented Apr 8, 2025

@magento run all tests

@engcom-Charlie engcom-Charlie added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Apr 8, 2025
@ajay2108
Copy link
Author

ajay2108 commented Apr 9, 2025

@engcom-Charlie - Please verify above PR. It is showing failure of some automatic checks which are not related to my commit. Can you please have a look and let me know if anything is required from my end.

@engcom-Charlie
Copy link
Contributor

Hi @ajay2108,

Thank you for your contribution!

Currently we are working on the priority board. Team will surely pick this PR as per priority.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't upload image for custom customer address attribute
2 participants