magento/magento2#39905 Product Removed on Mobile Still Appears in Web's Mini Compare Section Until Re-login

[KrasnoshchokBohdan]

Description (*)

createCompareList

mutation {
  createCompareList(
    input: {
      products: ["1", "2"]
    }
  ) {
    uid
    item_count
    attributes {
      code
      label
    }
    items {
      uid
      product {
        sku
        name
        description {
          html
        }
      }
    }
  }
}

addProductsToCompareList

mutation {
  addProductsToCompareList(
    input: { uid: "-", products: ["3"] }
  ) {
    uid
    item_count
    attributes {
      code
      label
    }
    items {
      uid
      product {
        sku
        name
        description {
          html
        }
      }
    }
  }
}

removeProductsFromCompareList

mutation {
  removeProductsFromCompareList(
    input: { uid: "-", products: ["2"] }
  ) {
    uid
    item_count
    attributes {
      code
      label
    }
    items {
      uid
      product {
        sku
        name
        description {
          html
        }
      }
    }
  }
}

After these mutations, the counter in the header and in the customer account does not change. I found \Magento\Catalog\Helper\Product\Compare::calculate, which updates the quantity in _catalogSession, but the counters actually get their data from the customer data (compare-products section). To get an accurate quantity, the session needs to be updated, which is quite contradictory when considering the issue in the GraphQL scope.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento2#39905

Manual testing scenarios (*)

1. Use any GraphQL mutation from the PR description.
2. Log in as a customer and go to /catalog/product_compare/index/
3. Go to /customer/account/index/ and check the "Compare Products" section.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)
• [ ]

[m2-assistant]

Hi @KrasnoshchokBohdan. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[KrasnoshchokBohdan]

@magento run all tests

[Den4ik]

Hi @KrasnoshchokBohdan
Thanks for your PR.
Could you please fix static tests and add new tests for fixed issue?
Thanks

[KrasnoshchokBohdan]

@Den4ik Hi!
Sorry to bother you. I probably should have marked this as a draft immediately.
Currently, I'm struggling with a solution for reloading the compare-product customer section after changes made by a GraphQL mutation (

[Den4ik]

Hi @KrasnoshchokBohdan
Thanks for details

[KrasnoshchokBohdan]

@magento run all tests

[KrasnoshchokBohdan]

@magento run all tests

[KrasnoshchokBohdan]

@magento run all tests