fix: Adaptive level for compatible Version formatting #3818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Jerphanion <[email protected]>
jjerphan
commented
Feb 12, 2025
| out = fmt::format_to( | ||
| out, | ||
| "{}{}", | ||
| VersionSpec::compatible_str, | ||
| pred.m_version.str(op.level) |
There was a problem hiding this comment.
Note to reviewers: this line caused the bug as the solver relies on the valid assumption that:
std::string match_spec_as_str = "numpy~=1.26"; // for instance.
match_spec_as_str == MatchSpec::parse(match_spec_as_str).value().str()here:
mamba/libmamba/src/solver/libsolv/helpers.cpp
Line 860 in ad9b2d6
which was not verified for compatible versions.
I think we need to add tests cases (in another PR) to test that this is valid for many MatchSpec.
jjerphan
commented
Feb 12, 2025
Comment on lines
+140
to
+142
| // TODO: test this assumption for many more cases | ||
| auto ms2 = MatchSpec::parse(ms.str()).value(); | ||
| REQUIRE(ms2 == ms); |
There was a problem hiding this comment.
Note to reviewers: this can be implemented in another PR.
JohanMabille
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3647.
Fix #3472 properly, reverting parts of #3483.