Fix nushell env for Windows #3880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In nushell, PATH variable is a list, not a string. After load-env, must set $env.PATH to a list.
In nushell, PATH variable is a list, not a string. After load-env, must set $env.PATH to a list.
|
pinging @AntoinePrv |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3880 +/- ##
=======================================
Coverage ? 62.91%
=======================================
Files ? 300
Lines ? 37124
Branches ? 2780
=======================================
Hits ? 23356
Misses ? 13716
Partials ? 52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AntoinePrv
approved these changes
Apr 25, 2025
|
I'm no nu expert but this seems good. One question @cvanelteren, does this break currently initiated nushells? For example, if one user has |
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fixed pr initialized by @Wuvist. Unfortunately he is MIA. I fixed the commits on that PR and want to push this to the repo to ensure that new users won't have this issue.
What does this PR do?
My initial implementation works well for unix but does not generalize well for windows-based machines. This PR addresses this while fixing an issue that the path was converted to a string.