Fix segfault in error messages #3912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoinePrv
changed the title
3 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3912 +/- ##
=======================================
Coverage ? 63.40%
=======================================
Files ? 300
Lines ? 37156
Branches ? 2782
=======================================
Hits ? 23557
Misses ? 13546
Partials ? 53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jjerphan
approved these changes
Apr 30, 2025
| { | ||
| auto db = solver::libsolv::Database{ channel_context.params() }; | ||
| const auto xpt = db.add_repo_from_repodata_json( | ||
| mambatests::test_data_dir / "repodata/sudoku.json", |
There was a problem hiding this comment.
I guess it is fine if we cannot support fetching remote files.
There was a problem hiding this comment.
This is a reasonably small (30'000l) file that I committed it to the repo. It's also nice to keep the test independent from the rest of Mamba.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3874