Update jQuery UI to 1.14.1 #1171
Conversation
|
Thank you, I will look into as soon as I find some time... |
|
@mar10 If you are referring to jQueryUI, the only breaking changes are: -Backward compatibility with the 1.11 API is disabled by default (https://blog.jqueryui.com/2024/08/jquery-ui-1-14-0-released/) But I was not able to build the ./dist content with grunt to test locally. Is there any command to run to do that? I wasn't ableo find it. EDIT: grunt clean:dist copy:build cssmin copy:ui_deps copy:dist replace:release I was able to build and then copy to dist to test the fork locally in my project. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Copilot reviewed 49 out of 68 changed files in this pull request and generated no comments.
Files not reviewed (19)
- demo/sample-3rd-confirm.html: Language not supported
- demo/sample-3rd-contextmenu-abs.html: Language not supported
- demo/sample-3rd-grid-scrollbar.html: Language not supported
- demo/sample-3rd-jQuery-contextMenu.html: Language not supported
- demo/sample-3rd-ui-contextmenu.html: Language not supported
- demo/sample-accordion.html: Language not supported
- demo/sample-configurator.html: Language not supported
- demo/sample-events.html: Language not supported
- demo/sample-ext-childcounter.html: Language not supported
- demo/sample-ext-columnview.html: Language not supported
- demo/sample-ext-dnd.html: Language not supported
- demo/sample-ext-edit.html: Language not supported
- demo/sample-ext-filter.html: Language not supported
- demo/sample-ext-fixed.html: Language not supported
- demo/sample-ext-glyph-awesome3.html: Language not supported
- demo/sample-ext-glyph-awesome4.html: Language not supported
- demo/sample-ext-glyph-awesome5.html: Language not supported
- demo/sample-ext-glyph-bootstrap3.html: Language not supported
- demo/sample-ext-glyph-material.html: Language not supported
Comments suppressed due to low confidence (1)
CHANGELOG.md:6
- [nitpick] Consider revising the formatting of this bullet point to match the style of other changelog entries. For example, you might remove the leading '-' if it could be confused with a diff marker.
+- #1171 Update jQuery to 3.7.1 and jQuery UI to 1.14.1
There was a problem hiding this comment.
Copilot reviewed 49 out of 68 changed files in this pull request and generated no comments.
Files not reviewed (19)
- demo/sample-3rd-confirm.html: Language not supported
- demo/sample-3rd-contextmenu-abs.html: Language not supported
- demo/sample-3rd-grid-scrollbar.html: Language not supported
- demo/sample-3rd-jQuery-contextMenu.html: Language not supported
- demo/sample-3rd-ui-contextmenu.html: Language not supported
- demo/sample-accordion.html: Language not supported
- demo/sample-configurator.html: Language not supported
- demo/sample-events.html: Language not supported
- demo/sample-ext-childcounter.html: Language not supported
- demo/sample-ext-columnview.html: Language not supported
- demo/sample-ext-dnd.html: Language not supported
- demo/sample-ext-edit.html: Language not supported
- demo/sample-ext-filter.html: Language not supported
- demo/sample-ext-fixed.html: Language not supported
- demo/sample-ext-glyph-awesome3.html: Language not supported
- demo/sample-ext-glyph-awesome4.html: Language not supported
- demo/sample-ext-glyph-awesome5.html: Language not supported
- demo/sample-ext-glyph-bootstrap3.html: Language not supported
- demo/sample-ext-glyph-material.html: Language not supported
Comments suppressed due to low confidence (1)
CHANGELOG.md:6
- The changelog entry references ticket Update jQuery UI to 1.14.1 #1171, which is inconsistent with the PR metadata that mentions issue Update jQuery UI to Update jQuery UI to 1.14.1 #1170. Please verify and update the ticket reference for consistency.
- #1171 Update jQuery to 3.7.1 and jQuery UI to 1.14.1
Attempt to upgrade jQueryUI to 1.14.1
#1170