This repository was archived by the owner on Sep 16, 2024. It is now read-only.
App Deployer 4.3.2 #446
Merged
App Deployer 4.3.2 #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Isn't valid" = an existing ML database cannot be associated. Now logging a warning as throwing an exception proved to be too punitive for users.
- use try-with-resources for closeable objects - use diamond operator for object construction - use addAll() instead of iterating over every item and adding each one - use Map.computeIfAbsent() to simplify - use StringBuilder instead of concatenating strings inside of a loop - use equalsIgnoreCase when comparing values without caring about case
442 Log warning instead of throwing error when database directory isn't associated to a real database
Apply various code quality fixes, remove unused imports, use diamond operator, try-with-resources, etc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.