Skip to content

Cleanups #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2025
Merged

Cleanups #322

merged 2 commits into from
Mar 11, 2025

Conversation

kamuikatsurgi
Copy link
Member

@kamuikatsurgi kamuikatsurgi commented Mar 6, 2025

  • Fixes --monitor to correctly include lastStateIDFromBor.
  • Some minor CI and anvil setup cleanups to make the code cleaner and more sociable. (Mostly removing unnecessary lines and stuff).

@marcello33
Copy link
Contributor

LGTM.
2 minor things:

  • Can we preserve the fund_anvil_account script in the docker util folder? Just in case we want to run it for testing. However we can delete it from the .github folder now, it should not be needed, right?
  • Since you're here, can you remove the fund_anvil_account script execution from the --start command? If not needed, it can be removed also from the --cleanup command.
    Thanks

@kamuikatsurgi
Copy link
Member Author

Can we preserve the fund_anvil_account script in the docker util folder?

I deleted the fund_ganache_account script; fund_anvil_account is still there.

However we can delete it from the .github folder now, it should not be needed, right?

Removed fund_anvil_account from .github folder.

can you remove the fund_anvil_account script execution from the --start command? If not needed, it can be removed also from the --cleanup command.

Removed fundAnvilAccouts from --start and --cleanup.

@kamuikatsurgi kamuikatsurgi requested a review from a team March 6, 2025 16:57
@kamuikatsurgi kamuikatsurgi merged commit 2cdd141 into master Mar 11, 2025
5 checks passed
@kamuikatsurgi kamuikatsurgi deleted the krishang/anvil-cleanup branch March 11, 2025 07:12
@marcello33 marcello33 mentioned this pull request Mar 26, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants