Skip to content

MatrixRTC: Add combined toDeviceAndRoomKeyTransport #4792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 14, 2025
Merged

MatrixRTC: Add combined toDeviceAndRoomKeyTransport #4792

merged 15 commits into from
Apr 14, 2025

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Apr 9, 2025 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@toger5 toger5 changed the title MatrixRTC: Add to-device and room key transport MatrixRTC: Add combined to-device and room key transport Apr 10, 2025
@toger5 toger5 mentioned this pull request Apr 10, 2025
Open
46 tasks
Base automatically changed from valere/matrix_rtc_to_device_keys to develop April 10, 2025 08:41
@toger5 toger5 force-pushed the toger5/to-device-and-room-transport branch 2 times, most recently from c8cc225 to dfffcfb Compare April 10, 2025 16:42
@toger5 toger5 added T-Feature Request to add a new feature which does not exist right now T-Enhancement labels Apr 10, 2025
@toger5 toger5 changed the title MatrixRTC: Add combined to-device and room key transport MatrixRTC: Add combined toDeviceAndRoomKeyTransport Apr 10, 2025
@toger5 toger5 changed the title MatrixRTC: Add combined toDeviceAndRoomKeyTransport MatrixRTC: Add combined toDeviceAndRoomKeyTransport Apr 10, 2025
@toger5 toger5 force-pushed the toger5/to-device-and-room-transport branch 2 times, most recently from bc48739 to 82733d8 Compare April 10, 2025 23:38
@toger5 toger5 marked this pull request as ready for review April 11, 2025 08:01
@toger5 toger5 requested a review from a team as a code owner April 11, 2025 08:01
@toger5 toger5 requested a review from BillCarsonFr April 11, 2025 08:01
@toger5 toger5 force-pushed the toger5/to-device-and-room-transport branch 2 times, most recently from 7ab4a0f to 445981f Compare April 11, 2025 14:54
BillCarsonFr
BillCarsonFr reviewed Apr 11, 2025
View reviewed changes
Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it could be simplified

@toger5 toger5 force-pushed the toger5/to-device-and-room-transport branch from 2b25241 to a1f57bf Compare April 14, 2025 13:23
@toger5 toger5 requested a review from BillCarsonFr April 14, 2025 13:23
@toger5 toger5 force-pushed the toger5/to-device-and-room-transport branch from c953d67 to a9a0561 Compare April 14, 2025 14:02
BillCarsonFr
BillCarsonFr approved these changes Apr 14, 2025
View reviewed changes
Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toger5 toger5 added this pull request to the merge queue Apr 14, 2025
Merged via the queue into develop with commit 64e27f5 Apr 14, 2025
30 checks passed
@toger5 toger5 deleted the toger5/to-device-and-room-transport branch April 14, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillCarsonFr BillCarsonFr BillCarsonFr approved these changes

Assignees
No one assigned
Labels
T-Enhancement T-Feature Request to add a new feature which does not exist right now
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toger5 @BillCarsonFr