feat(ffi): Expose legacy SSO support infomation #5222
+25
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently Element X can't distinguish the cases where a homeserver only supports legacy SSO without OIDC (and password login isn't avaliable), and other server unreachable scenarios. This patch exposes legacy SSO support infomation so that Element X side can give a dedicated error message when it encounters a homeserver that can only support legacy SSO. Signed-off-by: Yorusaka Miyabi <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5222 +/- ##
==========================================
- Coverage 85.15% 85.14% -0.02%
==========================================
Files 329 329
Lines 36911 36911
==========================================
- Hits 31431 31427 -4
- Misses 5480 5484 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stefanceriu
requested changes
Jun 12, 2025
Comment on lines
345
to
347
| supports_oidc_login, | ||
| supports_sso_login, | ||
| supported_oidc_prompts, |
There was a problem hiding this comment.
I think it's nicer to leave the oidc fields together and move supports_sso_login one line lower.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Element X can't distinguish the cases where a homeserver only
supports legacy SSO without OIDC (and password login isn't avaliable),
and other server unreachable scenarios.
This patch exposes legacy SSO support infomation so that Element X side
can give a dedicated error message when it encounters a homeserver that
can only support legacy SSO.
Signed-off-by: Yorusaka Miyabi [email protected]