feat(event cache): return relations in their local ordering #5258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
bnjbvr
changed the title
bnjbvr
force-pushed
the
bnjbvr/load-related-events-with-position
branch
from
ec3a8cd to
f8321ca
Compare
bnjbvr
force-pushed
the
bnjbvr/linked-chunk-ordering
branch
from
68d7da4 to
5a55d8b
Compare
… any linked chunk, only the room one
…de the position of items
…osition in the duplicate set
One must now specify the target linked chunk; both callers would filter out items based on this after the fact, which is a bit overkill since most items would thus be filtered out on the sinking end.
…the relational linked chunk
…MemoryStore::filter_duplicate_events` And remove useless comments.
bnjbvr
force-pushed
the
bnjbvr/load-related-events-with-position
branch
from
f8321ca to
d268712
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that the relations returned by
RoomEventCache::event_with_relationsare now sorted by their position in the linked chunk, if available (events that can't be located in a linked chunk will be at the front of the array, as they might be "bundled" relations they should be handled in priority).This will make it possible, for a threaded timeline, to retrieve all related edits in a thread, and to correctly order them (if we've seen them in the main linked chunk first).
(In the meantime, we could even use it to include the edit to a latest thread event as the latest event 👀 Will look into that as a separate PR.)
On top of #5225. Part of #4869 / #5122.