Setup framework to do integration testing #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azrenbeth
force-pushed
the
azren/integration_tests
branch
from
7731817 to
d987aa6
Compare
Azrenbeth
changed the title
also added readme to tests/tmp/ so that the directory is present when cloning repo (otherwise tests fail)
| "INSERT INTO state_groups (id, room_id, event_id) VALUES ({},{},{});\n", | ||
| sg, | ||
| PGEscape(room_id), | ||
| PGEscape("left_blank") |
There was a problem hiding this comment.
Instead of using the slightly awful PGEscape here, can't we just do a bunch of client.execute(..) instead? It may be a touch slower but I think its much clearer.
There was a problem hiding this comment.
I used PGEscape because this is the same code used when the compressor generates the SQL in lib.rs (where we should have PGEscape or at least some sort of safe escaping) - and so if the reader can understand one they can understand both
I added information in the next PR to the workspace README on how to run the tests allong with info on all the other running options |
erikjohnston
approved these changes
Aug 24, 2021
Co-authored-by: Erik Johnston <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUILDS ON azren/stats_tests (PR #49)
Setup ability to do integration tests.
This done by starting a postgres docker image and running the tests using that.
NOTE: not currently run by github actions