Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Reenable opentracing in _handle_new_device_update_async #12559

Open
@DMRobertson

Description

@DMRobertson

In #12552 we encountered pain because of a log_kv call that was not correctly associated with an opentracing span.

#12554 avoided the pain by commenting out the call to log_kv.

It's still useful to have this data available for debugging. We should fix this so that we are able to log_kv once more. #12552 (comment) describes two possible ways to do so. The error mentioned in its last paragraph has been fixed by #12555.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-Device-List-TrackingTelling clients about other devices. Often related to E2EE.A-LoggingSynapse's logs (structured or otherwise). Not metrics.S-TolerableMinor significance, cosmetic issues, low or no impact to users.T-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions