-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
require is not defined #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Trying to fix Currency Cop to the new PoE League, devs arent keeping it UTD so I wanted to fix it. https://github.com/currency-cop/currency-cop running into webpack errors already did nodeIntegration: true |
I'v found that this issue produced by postinstall switching between envs (electron/web). Need to switch to @angular-builders/custom-webpack - will add pull request next week |
@zombodotcom I am having the same issue. Is there anything we can do to help @cheplv? |
Will try give commit today. It's quite simple )) |
Add support for @angular-builders/custom-webpack Setup environment target based on env params Remove direct code changeing scripts postinstall/postinstall-web
@zombodotcom @Brandon9598 @maximegris |
thanks, i forgot I posted this. I got a lot further on my app. Thanks <3 |
I am still getting this! Pulled the latest master
main.ts: 18
|
@maximegris Need to reopen ticket - I'v found another one thing that needs to be added. |
sorry i was the one who closed it. i forgot what i did to fix it, didn't realize this was such a large issue. |
yeah )) thx |
@maximegris PR that fixes security issue serving app on localhost |
@uzumakinaruto123 can you check my PR and confirm that changes solve your issue? |
it seems that some days ago angular devs added support for custom webpack configuration: |
I pulled your PR and apparently everything was working. It works with a clean project. It does not work in the project I am actually working on! I think I messed up some dependencies while merging another project into this one. Steps to make an existing project compatible with this one would be helpful. Like, mentioning minimum dependencies and their versions. I tried merging https://github.com/akveo/ngx-admin/blob/master/package.json in angular-electron. |
@uzumakinaruto123 you need to merge deps of project (package.json) step by step, seems that src and e2e folder can be just copy/paste with override. |
@cheplv Thanks a lot! I just tried it once and for the first attempt I decided to keep the latest versions of the two for common dependencies. EDIT: |
@cheplv I just clone master branch and saw this error on browser. Any news about this isuse? |
@ardai96 can you describe - how you get that error - step by step |
|
@ardai96 "npm start" is intended to use only in electron environment i.e. opening direct localhost:4200 in browser will produce "require error" due build is for electron. |
Hi all, |
@fbaldo31 how you face this error? if you used steps which mentioned in #395 (comment) - so this is incorrect use - you need only 3 first steps - opening in localhost etc is not intended - use internal electron app dev tools |
|
@fbaldo31 ensure that you are latest master - due there was many changes in build/test process. |
I have solved my issue, probably due by moving files :/ |
@zombodotcom @maximegris think that we can close this issue |
Thanks @cheplv |
The text was updated successfully, but these errors were encountered: