boards: intel_s1000: remove (redundant) runner arguments

The runner argument backend currently no longer accepts setting common
configuration values through board_runner_args() and
board_finalize_runner_args().

This is affecting the intel_s1000 board's CMake configuration, causing
errors when 'west flash' et al are run.

However, the options in board_finalize_runner_args() appear to be
unnecessary (and likely shouldn't be there at all), as they are just
hard-coding the same values set elsewhere in the build system.

Let's have a single point of truth and remove them from the board
file. This has the side effect of restoring 'make flash'.

Fixes: zephyrproject-rtos#7986

Signed-off-by: Marti Bolivar <[email protected]>

Author: Marti Bolivar

boards/common/intel_s1000_crb.board.cmake

@@ -2,11 +2,8 @@ set(BOARD_FLASH_RUNNER intel_s1000)
 set(BOARD_DEBUG_RUNNER intel_s1000)
 
 board_finalize_runner_args(intel_s1000
-  "--board-dir=${ZEPHYR_BASE}/boards/xtensa/intel_s1000_crb/"
   "--xt-ocd-dir=/opt/Tensilica/xocd-12.0.4/xt-ocd"
   "--ocd-topology=topology_dsp0_flyswatter2.xml"
   "--ocd-jtag-instr=dsp0_gdb.txt"
   "--gdb-flash-file=load_elf.txt"
-  "--gdb=${TOOLCHAIN_HOME}/bin/xt-gdb"
-  "--kernel-elf=zephyr/zephyr.elf"
 )