-
Notifications
You must be signed in to change notification settings - Fork 7.5k
The scripts (debug, debugserver and flash) are not working for Intel S1000 board #7986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The runner argument backend currently no longer accepts setting common configuration values through board_runner_args() and board_finalize_runner_args(). This is affecting the intel_s1000 board's CMake configuration, causing errors when 'west flash' et al are run. However, the options in board_finalize_runner_args() appear to be unnecessary (and likely shouldn't be there at all), as they are just hard-coding the same values set elsewhere in the build system. Let's have a single point of truth and remove them from the board file. This has the side effect of restoring 'make flash'. Fixes: zephyrproject-rtos#7986 Signed-off-by: Marti Bolivar <[email protected]>
@rgundi the surface cause of the issue is that the flasher has internally moved the "common" configuration values like the board directory, kernel elf, etc. away from what you can set with board_finalize_runner_args(). I think this is not the root cause of the issue. I took a look at boards/common/intel_s1000_crb.board.cmake (by the way, this entire file should just be inlined into boards/xtensa/intel_s1000_crb/board.cmake, since there is nothing "common" about its contents). I see some suspicious lines that appear to be the real root cause, rather than the west changes: Specifically:
Since I can't build for your board as it does not have a publicly available toolchain, I am just guessing here. I have submitted a PR that I think fixes these issues (#8076); could you please test? Thanks! |
@rgundi I see. Thanks for your work locating this commit as a problem. Do you have some more details, since I can't run this without the board and access to the toolchain? Output from these commands (when run from your build directory) would be useful:
|
@rgundi can you please provide the requested information? @sathishkuttan can you help with this as well? |
@mbolivar .. below is the output from these commands.
|
this actually works, but I would not call this flashing, the script needs to be adapted to do flashing over USB which this is supported. Closing this for now. |
This was working before. Looks like the commit bc7b1c5 regressed it.
The text was updated successfully, but these errors were encountered: