boot: bootutil: swap_offset: Fix maximum application size #2269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes this functionality to have the maximum allowable application size Signed-off-by: Jamie McCrae <[email protected]>
de-nordic
reviewed
Apr 17, 2025
de-nordic
reviewed
Apr 17, 2025
Comment on lines
+345
to
+347
| if (num_sectors_pri != num_sectors_sec && | ||
| (num_sectors_pri + 1) != num_sectors_sec && | ||
| num_usable_sectors != (num_sectors_sec - 1)) { |
There was a problem hiding this comment.
Hm. The allowed primary will be always at least one page shorter than secondary, because that page is used for swapping, so:
num_sectors_pri - 1 >= num_sectors_sec
is the first condition.
From that we have sectors really available for image as:
num_usable_sectors = num_sectors_sec - int((trailer_sz + PAGE_SIZE - 1) / PAGE_SIZE)
That is how much could be uploaded if num_sectors_pri - 1 >= num_sectors_sec. Secondary slot sets the limit.
If we have
num_sectors_pri - 1 < num_sectors_sec
then:
num_usable_sectors = (num_sectors_pri - 1) - int((trailer_sz + PAGE_SIZE - 1) / PAGE_SIZE)
That is how much could be swapped, the primary slot sets the limit.
de-nordic
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this functionality to have the maximum allowable application size