Skip to content

FF89 large ArrayBuffers #4470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 30, 2021
Merged

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Apr 26, 2021

This is partial fix for #4314.

This is in draft because still clarifying the inconsistency in the invalid array length docs.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2021

Preview URLs

Flaws

Note! 4 documents with no flaws that don't need to be listed. 🎉

none! 🎉

External URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Array
Title: Array
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/length
Title: Array.prototype.length
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/ArrayBuffer
Title: ArrayBuffer
on GitHub


URL: /en-US/docs/Web/JavaScript/Reference/Errors/Invalid_array_length
Title: RangeError: invalid array length
on GitHub

No external URLs

(this comment was updated 2021-04-26 04:46:32.697245)

(this comment was updated 2021-04-30 06:46:31.771195)

(this comment was updated 2021-04-30 06:53:08.045574)

(this comment was updated 2021-04-30 06:58:52.173376)

(this comment was updated 2021-04-30 07:00:42.970795)

@hamishwillee hamishwillee marked this pull request as ready for review April 30, 2021 06:52
@hamishwillee hamishwillee requested review from a team as code owners April 30, 2021 06:52
@hamishwillee hamishwillee requested review from chrisdavidmills and removed request for a team April 30, 2021 06:52
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks @hamishwillee !

@chrisdavidmills chrisdavidmills merged commit 170b0b7 into mdn:main Apr 30, 2021
wbamberg pushed a commit to wbamberg/content that referenced this pull request Apr 30, 2021
* upstream/main:
  Fix some typos: (mdn#4620)
  Fix information for fullscreenchange event (mdn#4603)
  FF89 large ArrayBuffers (mdn#4470)
  fix: HTML Validation issues (mdn#4612)
  Make warnings consistent in the JS docs (mdn#4609)
  fixed typo (mdn#4617)
  chore(deps): bump @mdn/yari from 0.4.412 to 0.4.413 (mdn#4616)
  chore(deps): bump technote-space/get-diff-action from v4.0.6 to v4.1.1 (mdn#4615)
@hamishwillee hamishwillee deleted the ff89_large_arraybuffers branch May 3, 2021 01:11
<p>The maximum allowed array length depends on the platform, browser and browser version. For {{jsxref("Array")}} the maximum length is 2GB-1 (2^32-1). For {{jsxref("ArrayBuffer")}} the maximum is 2GB-1 on 32-bit systems (2^32-1). From Firefox version 89 the maximum value of {{jsxref("ArrayBuffer")}} is 8GB on 64-bit systems (2^33).</p>

<div class="notecard note">
<p><strong>Note:</strong> <code>Array</code> and <code>ArrayBuffer</code> are independent data structures (the implementation of one does not affect the other)..</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Double period at the end of this sentence.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lars-t-hansen - fixed by #4665 . Appreciate the review.

Copy link

@lars-t-hansen lars-t-hansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible to me, modulo not.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants