Update linker detection for ELD #14746
Conversation
ELD updated the output for `--version` flag qualcomm/eld#156 this commit updates detection for new output. Signed-off-by: Kushal Pal <[email protected]>
| @@ -166,7 +166,7 @@ def guess_nix_linker(env: 'Environment', compiler: T.List[str], comp_class: T.Ty | |||
|
|
|||
| linker = lld_cls( | |||
| compiler, for_machine, comp_class.LINKER_PREFIX, override, system=system, version=v) | |||
| elif 'Hexagon' in o and 'LLVM' in o: | |||
| elif o.startswith("eld"): | |||
There was a problem hiding this comment.
Doesn't this make the detection fail for the old output?
There was a problem hiding this comment.
yes, but eld detection was recently added in meson, this should be fine right?
There was a problem hiding this comment.
I don't see the connection between the fact that eld support in Meson is recent with requiring the latest version of eld to be installed for the Meson support to work. I'm not familiar with how eld is distributed and I didn't find any release information on the linked github project, however, I suppose support for more than (literally) last week git master is desirable.
There was a problem hiding this comment.
If there's a released version of eld that only works with the old detection method we need to check both. I'm happy to put the o.startswith(..) first
There was a problem hiding this comment.
ELD was open sourced recently (April 2025), and does not have any official release yet,
So there is no need to worry about backwards compatibility as the first official release version is yet to come
ELD updated the output for
--versionflag qualcomm/eld#156 this commit updates detection for new output.