Skip to content

📖 Update e2e feature tests triggers #1564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mboukhalfa
Copy link
Member

After migrating to prow jenkins operator and merging changes to trigger feature tests from prow this PR update the triggers on readme.md

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 25, 2024
@mboukhalfa
Copy link
Member Author

/test metal3-ubuntu-e2e-feature-test-main

@kashifest kashifest changed the title Update e2e feature tests triggers 📖 Update e2e feature tests triggers Mar 26, 2024
@kashifest
Copy link
Member

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2024
@kashifest
Copy link
Member

/hold
Please fix the tests and also DCO check

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2024
@mboukhalfa
Copy link
Member Author

/test metal3-ubuntu-e2e-feature-test-main

1 similar comment
@mboukhalfa
Copy link
Member Author

/test metal3-ubuntu-e2e-feature-test-main

@mboukhalfa mboukhalfa force-pushed the e2e-feature-triggers/mboukhalfa branch 2 times, most recently from 1fc1b0d to b542cd5 Compare March 28, 2024 08:17
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 28, 2024
README.md Outdated
version v1beta1 and branch release-1.6 on Ubuntu
- **/test-centos-e2e-feature-release-1-6** runs e2e feature tests with CAPM3 API
version v1beta1 and branch release-1.6 on CentOS
- **/test metal3-centos-e2e-feature-test-release-1-6** runs e2e feature tests with
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all are changing ubuntu to centos

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@mboukhalfa mboukhalfa force-pushed the e2e-feature-triggers/mboukhalfa branch from b542cd5 to 6a3ca4b Compare March 28, 2024 08:25
Signed-off-by: Mohammed Boukhalfa <[email protected]>
@mboukhalfa mboukhalfa force-pushed the e2e-feature-triggers/mboukhalfa branch from 6a3ca4b to 315f3cf Compare March 28, 2024 08:27
@Sunnatillo
Copy link
Member

/test-centos-e2e-integration-main

testing

@mboukhalfa
Copy link
Member Author

/test metal3-ubuntu-e2e-feature-test-main

Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, Sunnatillo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Sunnatillo
Copy link
Member

/hold Please fix the tests and also DCO check

DCO issue is fixed.
/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2024
@Sunnatillo
Copy link
Member

/override test-centos-e2e-integration-main
/override test-ubuntu-integration-main

@metal3-io-bot
Copy link
Contributor

@Sunnatillo: Sunnatillo unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to this:

/override test-centos-e2e-integration-main
/override test-ubuntu-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboukhalfa
Copy link
Member Author

/override test-centos-e2e-integration-main

@metal3-io-bot
Copy link
Contributor

@mboukhalfa: Overrode contexts on behalf of mboukhalfa: test-centos-e2e-integration-main

In response to this:

/override test-centos-e2e-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboukhalfa
Copy link
Member Author

mboukhalfa commented Apr 2, 2024

/override test-ubuntu-integration-main

1 similar comment
@mboukhalfa
Copy link
Member Author

/override test-ubuntu-integration-main

@metal3-io-bot
Copy link
Contributor

@mboukhalfa: Overrode contexts on behalf of mboukhalfa: test-ubuntu-integration-main

In response to this:

/override test-ubuntu-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot merged commit cbf7fff into metal3-io:main Apr 2, 2024
13 checks passed
@metal3-io-bot metal3-io-bot deleted the e2e-feature-triggers/mboukhalfa branch April 2, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants