Skip to content

Add update strategy to Metal3DataTemplate #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2021
Merged

Add update strategy to Metal3DataTemplate #169

merged 1 commit into from
Apr 1, 2021

Conversation

kashifest
Copy link
Member

Due to the immutability of the Metal3DataTemplate, it was not possible
to update properly the metadata and network data for a
Metal3MachineTemplate. This commits adds an update strategy to allow
the user to create a new template and transition to it via rolling
upgrade of the CAPI machine deployments or KCP.

@metal3-io-bot metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 16, 2021
@maelk
Copy link
Member

maelk commented Mar 22, 2021

Is this still WIP ?

@kashifest kashifest changed the title WIP: Add update strategy to Metal3DataTemplate Add update strategy to Metal3DataTemplate Mar 22, 2021
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 22, 2021
@kashifest
Copy link
Member Author

/cc @maelk @fmuyassarov

@kashifest kashifest force-pushed the update/m3dat-mutability branch from 2a4ea4e to 3bf3c3d Compare March 23, 2021 07:24
maelk
maelk reviewed Mar 23, 2021
View reviewed changes
Copy link
Member

@maelk maelk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me overall. Maybe the naming "templateReference" is not optimal since it can be quite obscure when in the m3dt itself, what about just "reference" ? or any other idea ?

@kashifest
Copy link
Member Author

This looks good to me overall. Maybe the naming "templateReference" is not optimal since it can be quite obscure when in the m3dt itself, what about just "reference" ? or any other idea ?

I would rather keep it as templateReference just to be crystal clear since there can be other types of references in future, ofcourse if no strong opinions against it.

@kashifest kashifest force-pushed the update/m3dat-mutability branch 2 times, most recently from ae4c1aa to 07f121e Compare March 26, 2021 15:07
fmuyassarov
fmuyassarov reviewed Mar 29, 2021
View reviewed changes
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maelk
Copy link
Member

maelk commented Mar 30, 2021

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2021
@kashifest
Add update strategy to Metal3DataTemplate
80973ec 
Due to the immutability of the Metal3DataTemplate, it was not possible
to update properly the metadata and network data for a
Metal3MachineTemplate. This commits adds an update strategy to allow
the user to create a new template and transition to it via rolling
upgrade of the CAPI machine deployments or KCP.
@kashifest kashifest force-pushed the update/m3dat-mutability branch from 07f121e to 80973ec Compare March 30, 2021 10:46
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2021
@kashifest
Copy link
Member Author

@maelk @fmuyassarov PTAL again. I have addressed the comments

@kashifest kashifest mentioned this pull request Mar 30, 2021
Merged
fmuyassarov
fmuyassarov reviewed Mar 30, 2021
View reviewed changes
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2021
@maelk
Copy link
Member

maelk commented Apr 1, 2021

/approve
Since there does not seem to be interest on this from others than our team (it was opened more than two weeks ago), let's proceed to merge it, it's a relative small change.

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, maelk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2021
@metal3-io-bot metal3-io-bot merged commit 8957976 into metal3-io:master Apr 1, 2021
@kashifest kashifest deleted the update/m3dat-mutability branch August 30, 2022 07:56
@kashifest kashifest restored the update/m3dat-mutability branch August 30, 2022 07:56
@kashifest kashifest deleted the update/m3dat-mutability branch August 30, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maelk maelk maelk left review comments

@fmuyassarov fmuyassarov fmuyassarov left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kashifest @maelk @metal3-io-bot @fmuyassarov