Skip to content

bump golang to 1.24 for IRSO #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

bump golang to 1.24 for IRSO #993

merged 1 commit into from
Apr 25, 2025

Conversation

tuminoid
Copy link
Member

IRSO needs golang 1.24 for mariadb-operator, so we need to bump it here as well. Other repos will follow when 1.10 cycle etc are done.

/cc @dtantsur @lentzi90

@tuminoid
bump golang to 1.24 for IRSO
294fbea 
IRSO needs golang 1.24 for mariadb-operator, so we need to bump it here
as well. Other repos will follow when 1.10 cycle etc are done.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 25, 2025
@tuminoid
Copy link
Member Author

/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adilGhaffarDev
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2025
kashifest
kashifest reviewed Apr 25, 2025
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2025
@metal3-io-bot metal3-io-bot merged commit 68b4589 into metal3-io:main Apr 25, 2025
5 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/bump-golang-for-irso branch April 25, 2025 07:16
@metal3-io-bot
Copy link
Collaborator

@tuminoid: Updated the job-config configmap in namespace prow at cluster default using the following files:

  • key ironic-standalone-operator.yaml using file prow/config/jobs/metal3-io/ironic-standalone-operator.yaml

In response to this:

IRSO needs golang 1.24 for mariadb-operator, so we need to bump it here as well. Other repos will follow when 1.10 cycle etc are done.

/cc @dtantsur @lentzi90

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifest kashifest kashifest left review comments

@dtantsur dtantsur Awaiting requested review from dtantsur

@lentzi90 lentzi90 Awaiting requested review from lentzi90

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuminoid @metal3-io-bot @adilGhaffarDev @kashifest