Skip to content

Fix several crashes #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 2, 2024
Merged

Fix several crashes #442

merged 3 commits into from
Apr 2, 2024

Conversation

ssvine
Copy link
Contributor

@ssvine ssvine commented Mar 31, 2024 •
edited
Loading

This pull request fixes this issue

  • When returning from a connection to the session list and then establishing the new connection, the latter will use old local path and edit histories
  • When returning from a connection to the session list with an open editor (editing a remote file), saving the file leads to a crash
  • Selecting non-existent file from edit history leads to a crash
  • History menu truncates names longer than 10 characters

ssvine added 3 commits March 31, 2024 05:48
@ssvine
Clear connection related state on disconnect
f4777ec 
When we return from a connection to the session list, we should clean up data that might be mistakenly reused in the new connection
@ssvine
Fix MaxMessageLines() and MaxMenuItemLength()
1788d6c
@ssvine
Fix crash when deleted file is selected in edit history
0a2aab8
@ssvine ssvine mentioned this pull request Mar 31, 2024
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@michaellukashov michaellukashov merged commit 6edb209 into michaellukashov:main Apr 2, 2024
2 checks passed
@ssvine ssvine deleted the fix-several-crashes branch April 3, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Несколько проблем и падений
2 participants
@ssvine @michaellukashov