Skip to content

Don't treat netbox file as archive when searching in archives #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 24, 2024

Conversation

ssvine
Copy link
Contributor

@ssvine ssvine commented Sep 27, 2024

This PR fixes #493

  1. It fixes ShowModal that can crash if DialogInit returned an invalid handle.
  2. Moreover, it disables very confusing behaviour — connecting to the servers when processing .netbox files on Alt-F7 (with [x] Search in archives) and Shift-F3 (Archive command).

In addition to this fixes, this PR also cleans some remainings of an old PR.

Copy link

@michaellukashov michaellukashov merged commit a529cbd into michaellukashov:main Nov 24, 2024
2 checks passed
@ssvine ssvine deleted the fix-analyze branch November 25, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NetBox.dll - Exception: 0xC0000005 - STATUS_ACCESS_VIOLATION
2 participants