Custom config locations should be used in bootstrap environment too #11772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graemerocher
approved these changes
Apr 23, 2025
graemerocher
added
the
type: improvement
…nfig locations so the array from the builder is not updated when Collections.reverse method is called on the list returned from getOverrideConfigLocations
… DefaultEnvironment constructor to create a new list before executing Collections.reverse
|
msupic
added a commit
that referenced
this pull request
Apr 28, 2025
…11772) * Custom config locations should be used in bootstrap environment too * Modified getOverrideConfigLocations method to return a new list of config locations so the array from the builder is not updated when Collections.reverse method is called on the list returned from getOverrideConfigLocations * Rolled back changes in getOverrideConfigLocations method and modified DefaultEnvironment constructor to create a new list before executing Collections.reverse * Code cleanup
altro3
pushed a commit
to altro3/micronaut-core
that referenced
this pull request
Jun 3, 2025
…icronaut-projects#11772) * Custom config locations should be used in bootstrap environment too * Modified getOverrideConfigLocations method to return a new list of config locations so the array from the builder is not updated when Collections.reverse method is called on the list returned from getOverrideConfigLocations * Rolled back changes in getOverrideConfigLocations method and modified DefaultEnvironment constructor to create a new list before executing Collections.reverse * Code cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.