fix config properties refresh for each property #11798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstepanov
requested changes
May 9, 2025
runtime/src/test/groovy/io/micronaut/runtime/context/scope/RefreshScopeSpec.groovy
Show resolved
Hide resolved
runtime/src/test/groovy/io/micronaut/runtime/context/scope/RefreshScopeSpec.groovy
Show resolved
Hide resolved
|
dstepanov
approved these changes
May 9, 2025
sdelamo
pushed a commit
that referenced
this pull request
Jun 11, 2025
The refresh endpoint doesn't work for `@EachProperty` beans. This means that datasource properties are not refreshed from the `/refresh` endpoint and other periodic refresh mechanisms. The reason this is broken is because: * The `@ConfigurationProperties` stereotype is used instead of `@ConfigurationReader` * The each property prefix is not handled * The `inject` method of the bean context doesn't set the path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refresh endpoint doesn't work for
@EachPropertybeans. This means that datasource properties are not refreshed from the/refreshendpoint and other periodic refresh mechanisms. The reason this is broken is because:@ConfigurationPropertiesstereotype is used instead of@ConfigurationReaderinjectmethod of the bean context doesn't set the path.