Skip to content

Fix: CI issue where branch names containing 'bootstrap' #4417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 10, 2025
Merged

Fix: CI issue where branch names containing 'bootstrap' #4417

merged 3 commits into from
Mar 10, 2025

Conversation

ShakutaiGit
Copy link
Collaborator

Resolves #4416

Updated the ACR login condition to check for 'make bootstrap' instead of just 'bootstrap' to avoid false positives.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 10, 2025 •
edited
Loading

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 0988a78.

♻️ This comment has been updated with latest results.

@ShakutaiGit ShakutaiGit requested review from marrobi and LizaShak March 10, 2025 10:55
@ShakutaiGit
Copy link
Collaborator Author

/test

@ShakutaiGit ShakutaiGit marked this pull request as ready for review March 10, 2025 11:05
@github-actions GitHub Actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13763114361 (with refid 4b645fa8)

(in response to this comment from @ShakutaiGit)

@ShakutaiGit ShakutaiGit self-assigned this Mar 10, 2025
@ShakutaiGit ShakutaiGit changed the title fix: update condition for Azure and ACR login to check for 'make bootsrap' Fix: CI issue where branch names containing 'bootstrap' Mar 10, 2025
@ShakutaiGit
Copy link
Collaborator Author

/test

@github-actions GitHub Actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13763268486 (with refid 4b645fa8)

(in response to this comment from @ShakutaiGit)

marrobi
marrobi approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShakutaiGit ShakutaiGit removed the request for review from LizaShak March 10, 2025 12:00
@ShakutaiGit ShakutaiGit enabled auto-merge (squash) March 10, 2025 12:03
@ShakutaiGit
Copy link
Collaborator Author

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13763268486 (with refid 4b645fa8)

(in response to this comment from @ShakutaiGit)

Tests Passed

@ShakutaiGit
Copy link
Collaborator Author

/test-force-approve

@github-actions GitHub Actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 0988a78)

(in response to this comment from @ShakutaiGit)

@ShakutaiGit ShakutaiGit merged commit ea0138c into main Mar 10, 2025
12 checks passed
@ShakutaiGit ShakutaiGit deleted the fix-acr-skip-bootsrap-4416 branch March 10, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marrobi marrobi marrobi approved these changes

@yuvalyaron yuvalyaron yuvalyaron approved these changes

Assignees

@ShakutaiGit ShakutaiGit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ACR Login Skipped Due to 'bootstrap' Match in Branch Name
3 participants
@ShakutaiGit @marrobi @yuvalyaron