Skip to content

Enable thread::hardware_concurrency() to handle more than 64 processors #5459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 10, 2025
Merged

Enable thread::hardware_concurrency() to handle more than 64 processors #5459

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f6a5f91
Fix #5453 to enable handling of over 64 processors
YexuanXiao May 2, 2025
968f5d1
Use GetLogicalProcessorInformationEx
YexuanXiao May 3, 2025
c8f3af4
Add missing header files
YexuanXiao May 3, 2025
66016db
Align the stack buffer and add noexcept to the lambda
YexuanXiao May 3, 2025
27fc44e
Use the #error directive to report unknown architectures
YexuanXiao May 3, 2025
924ea74
Consistency: `std::` => `_STD`
StephanTLavavej May 8, 2025
3494728
Directly test the `BOOL` returned by `GetLogicalProcessorInformationEx`.
StephanTLavavej May 8, 2025
dad053a
Drop comment about the size of `Mask`; `popcount` handles this.
StephanTLavavej May 8, 2025
0cf6aa2
Detect 64-bit / 32-bit variation with `_WIN64`.
StephanTLavavej May 8, 2025
c9e6c96
Restructure control flow with a loop instead of a lambda.
StephanTLavavej May 8, 2025
2f05336
`buffer` => `stack_buffer`
StephanTLavavej May 8, 2025
da4724c
`count` => `logical_processors`
StephanTLavavej May 8, 2025
06b7eae
Handle multiple sockets.
StephanTLavavej May 8, 2025
29bb4fe
Add comments.
StephanTLavavej May 8, 2025
c4c52f0
Fix the ARM64EC internal build.
StephanTLavavej May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions stl/src/cthread.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,7 @@ _CRTIMP2_PURE _Thrd_id_t __cdecl _Thrd_id() noexcept { // return unique id for c
}

_CRTIMP2_PURE unsigned int __cdecl _Thrd_hardware_concurrency() noexcept { // return number of processors
SYSTEM_INFO info;
GetNativeSystemInfo(&info);
return info.dwNumberOfProcessors;
return GetActiveProcessorCount(ALL_PROCESSOR_GROUPS);
}

// TRANSITION, ABI: _Thrd_create() is preserved for binary compatibility
Expand Down