Add casts to vector algorithms entry points #5471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexGuteniev
commented
May 4, 2025
tests/std/tests/GH_005421_vector_algorithms_integer_class_type_iterator/test.cpp
Outdated
Show resolved
Hide resolved
AlexGuteniev
commented
May 4, 2025
tests/std/tests/GH_005421_vector_algorithms_integer_class_type_iterator/test.cpp
Show resolved
Hide resolved
AlexGuteniev
commented
May 5, 2025
StephanTLavavej
requested changes
May 5, 2025
tests/std/tests/GH_005421_vector_algorithms_integer_class_type_iterator/test.cpp
Show resolved
Hide resolved
tests/std/tests/GH_005421_vector_algorithms_integer_class_type_iterator/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_005421_vector_algorithms_integer_class_type_iterator/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_005421_vector_algorithms_integer_class_type_iterator/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_005421_vector_algorithms_integer_class_type_iterator/test.cpp
Show resolved
Hide resolved
github-project-automation
bot
moved this from Initial Review
to Work In Progress
in STL Code Reviews
|
I was thinking whether the runtime test is needed at all, or compile-time would have been fine. Looks like the runtime test also checks the correctness of the unwrapped-to-non-pointer branches, which the main tests don't do, since most of them only use |
tests/std/tests/GH_005421_vector_algorithms_integer_class_type_iterator/test.cpp
Show resolved
Hide resolved
tests/std/tests/GH_005421_vector_algorithms_integer_class_type_iterator/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_005421_vector_algorithms_integer_class_type_iterator/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_005421_vector_algorithms_integer_class_type_iterator/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_005421_vector_algorithms_integer_class_type_iterator/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_005421_vector_algorithms_integer_class_type_iterator/test.cpp
Outdated
Show resolved
Hide resolved
|
Thanks! I fixed minor nitpicks and pushed a moderate simplification to the test. 😻 |
StephanTLavavej
approved these changes
May 9, 2025
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for adding these important |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5421