Skip to content

Fix num_get::do_get for bool on bad grouping #5476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2025
Merged

Fix num_get::do_get for bool on bad grouping #5476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions stl/inc/xlocnum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,15 +373,11 @@ protected:
char* _Ep;
int _Errno;
const long _Ans = _CSTD _Stolx(_Ac, &_Ep, _Parse_result._Base, &_Errno); // convert
if (_Ep == _Ac || _Errno != 0 // N4950 [facet.num.get.virtuals]/3
|| _Parse_result._Bad_grouping) { // N4950 [facet.num.get.virtuals]/4
_Val = true;
_Val = _Ans != 0;
if (_Ep == _Ac || _Errno != 0 // N5008 [facet.num.get.virtuals]/3
|| _Parse_result._Bad_grouping // N5008 [facet.num.get.virtuals]/4
|| (_Ans != 0 && _Ans != 1)) { // N5008 [facet.num.get.virtuals]/6
_State = ios_base::failbit;
} else {
_Val = _Ans != 0;
if (_Ans != 0 && _Ans != 1) {
_State = ios_base::failbit;
}
}
}
}
Expand Down
172 changes: 172 additions & 0 deletions tests/std/tests/GH_001277_num_get_bad_grouping/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,177 @@ void test_good_and_bad_grouping_pointer() {
}
}

// Also test GH-5470 "<xlocnum>: num_get::do_get for bool stores true in the result when the input has bad grouping,
// even if the input is zero"
void test_good_and_bad_grouping_bool() {
const my_facet f(1);
ios instr(nullptr);
instr.imbue(locale(locale(), new special_numpunct));

instr.setf(ios_base::fmtflags{}, ios_base::basefield);

{
bool v = true;
const char sep_str[] = "0";
const size_t len = sizeof(sep_str) - 1;
ios_base::iostate err = instr.goodbit;
const char* iter = f.get(sep_str, sep_str + len + 1, instr, err, v);
assert(iter == sep_str + len);
assert(err == instr.goodbit);
assert(!v);
}
{
bool v = true;
const char sep_str[] = "-0";
const size_t len = sizeof(sep_str) - 1;
ios_base::iostate err = instr.goodbit;
const char* iter = f.get(sep_str, sep_str + len + 1, instr, err, v);
assert(iter == sep_str + len);
assert(err == instr.goodbit);
assert(!v);
}
{
bool v = true;
const char sep_str[] = "1";
const size_t len = sizeof(sep_str) - 1;
ios_base::iostate err = instr.goodbit;
const char* iter = f.get(sep_str, sep_str + len + 1, instr, err, v);
assert(iter == sep_str + len);
assert(err == instr.goodbit);
assert(v);
}
{
bool v = true;
const char sep_str[] = "1,72,9";
const size_t len = sizeof(sep_str) - 1;
ios_base::iostate err = instr.goodbit;
const char* iter = f.get(sep_str, sep_str + len + 1, instr, err, v);
assert(iter == sep_str + len);
assert(err == instr.failbit);
assert(v);
}
{
bool v = true;
const char sep_str[] = "0,17,7";
const size_t len = sizeof(sep_str) - 1;
ios_base::iostate err = instr.goodbit;
const char* iter = f.get(sep_str, sep_str + len + 1, instr, err, v);
assert(iter == sep_str + len);
assert(err == instr.failbit);
assert(v);
}
{
bool v = true;
const char sep_str[] = "0,00,1";
const size_t len = sizeof(sep_str) - 1;
ios_base::iostate err = instr.goodbit;
const char* iter = f.get(sep_str, sep_str + len + 1, instr, err, v);
assert(iter == sep_str + len);
assert(err == instr.goodbit);
assert(v);
}
{
bool v = true;
const char sep_str[] = "0,00,0";
const size_t len = sizeof(sep_str) - 1;
ios_base::iostate err = instr.goodbit;
const char* iter = f.get(sep_str, sep_str + len + 1, instr, err, v);
assert(iter == sep_str + len);
assert(err == instr.goodbit);
assert(!v);
}
{
bool v = true;
const char sep_str[] = "01,77";
const size_t len = sizeof(sep_str) - 1;
ios_base::iostate err = instr.goodbit;
const char* iter = f.get(sep_str, sep_str + len + 1, instr, err, v);
assert(iter == sep_str + len);
assert(err == instr.failbit);
assert(v);
}
{
bool v = true;
const char sep_str[] = "00,01";
const size_t len = sizeof(sep_str) - 1;
ios_base::iostate err = instr.goodbit;
const char* iter = f.get(sep_str, sep_str + len + 1, instr, err, v);
assert(iter == sep_str + len);
assert(err == instr.failbit);
assert(v);
}
{
bool v = true;
const char sep_str[] = "00,00";
const size_t len = sizeof(sep_str) - 1;
ios_base::iostate err = instr.goodbit;
const char* iter = f.get(sep_str, sep_str + len + 1, instr, err, v);
assert(iter == sep_str + len);
assert(err == instr.failbit);
assert(!v);
}
{
bool v = true;
const char sep_str[] = "0x1,72,9";
const size_t len = sizeof(sep_str) - 1;
ios_base::iostate err = instr.goodbit;
const char* iter = f.get(sep_str, sep_str + len + 1, instr, err, v);
assert(iter == sep_str + len);
assert(err == instr.failbit);
assert(v);
}
{
bool v = true;
const char sep_str[] = "0x0,00,1";
const size_t len = sizeof(sep_str) - 1;
ios_base::iostate err = instr.goodbit;
const char* iter = f.get(sep_str, sep_str + len + 1, instr, err, v);
assert(iter == sep_str + len);
assert(err == instr.goodbit);
assert(v);
}
{
bool v = true;
const char sep_str[] = "0x0,00,0";
const size_t len = sizeof(sep_str) - 1;
ios_base::iostate err = instr.goodbit;
const char* iter = f.get(sep_str, sep_str + len + 1, instr, err, v);
assert(iter == sep_str + len);
assert(err == instr.goodbit);
assert(!v);
}
{
bool v = true;
const char sep_str[] = "0x1,729";
const size_t len = sizeof(sep_str) - 1;
ios_base::iostate err = instr.goodbit;
const char* iter = f.get(sep_str, sep_str + len + 1, instr, err, v);
assert(iter == sep_str + len);
assert(err == instr.failbit);
assert(v);
}
{
bool v = true;
const char sep_str[] = "0x0,001";
const size_t len = sizeof(sep_str) - 1;
ios_base::iostate err = instr.goodbit;
const char* iter = f.get(sep_str, sep_str + len + 1, instr, err, v);
assert(iter == sep_str + len);
assert(err == instr.failbit);
assert(v);
}
{
bool v = true;
const char sep_str[] = "0x0,000";
const size_t len = sizeof(sep_str) - 1;
ios_base::iostate err = instr.goodbit;
const char* iter = f.get(sep_str, sep_str + len + 1, instr, err, v);
assert(iter == sep_str + len);
assert(err == instr.failbit);
assert(!v);
}
}

class mid_zero_numpunct : public numpunct<char> {
public:
mid_zero_numpunct() : numpunct<char>() {}
Expand Down Expand Up @@ -449,6 +620,7 @@ int main() {
test_good_and_bad_grouping<double>();
test_good_and_bad_grouping<long double>();
test_good_and_bad_grouping_pointer();
test_good_and_bad_grouping_bool();

test_nonending_unlimited_grouping<unsigned int>();
test_nonending_unlimited_grouping<long>();
Expand Down