Navtree doesn't return computed class members

[jrieken]

TS Template added by @mjbvz

TypeScript Version: 4.1

Search Terms

• navtree
• outline

---

• have the TS file below
• open outline, breadcrumbs, or quick outline
• 🐛 the members [State.WAIT_FOR_INPUT] and [State.INIT_UI] are missing

const enum State {
	INIT_UI = 'INIT_UI',
	WAIT_FOR_INPUT = 'WAIT_FOR_INPUT',
}

class AAAAA {

    [State.INIT_UI]() {
        return 23;
    }

    [State.WAIT_FOR_INPUT](){
        return 43;
    }

    bbbbb() {
        return 333;
    }
}

[jrieken]

@mjbvz this seems to be tsserver unless there is a request flag that we need to set

[a-tarasyuk]

TypeScript/src/services/navigationBar.ts

Lines 309 to 322 in 58f0300

	/**
	* Historically, we've elided dynamic names from the nav tree (including late bound names),
	* but included certain "well known" symbol names. While we no longer distinguish those well-known
	* symbols from other unique symbols, we do the below to retain those members in the nav tree.
	*/
	function hasNavigationBarName(node: Declaration) {
	return !hasDynamicName(node) ||
	(
	node.kind !== SyntaxKind.BinaryExpression &&
	isPropertyAccessExpression(node.name.expression) &&
	isIdentifier(node.name.expression.expression) &&
	idText(node.name.expression.expression) === "Symbol"
	);
	}

[RyanCavanaugh]

It seems like it would just be totally fine to include any dotted name or bare identifier in this list. I don't see any downside of doing that, and it would make the code cleaner too.

[DanielRosenwasser]

Thanks @a-tarasyuk!