Skip to content

Check if its same buildinfo only for directly referenced projects and not recursively #50617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

sheetalkamat
Copy link
Member

Thats because we issue errors only for direct references and not indirect references when creating program so no need to check recursively for uptodate-ness check either.

Fixes #50545

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Sep 2, 2022
@sheetalkamat
Copy link
Member Author

@typescript-bot cherry-pick this to release-4.8

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 2, 2022

Heya @sheetalkamat, I've started to run the task to cherry-pick this into release-4.8 on this PR at 83a58b0. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @sheetalkamat, I've opened #50618 for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.8 hasSameBuildInfo can randomly crash tsc.js with "Cannot read properties of undefined (reading 'path')"
4 participants