Skip to content

Partially revert #41044, restoring parameter destructurings in d.ts files #50779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2022

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Sep 14, 2022

Fixes #50707 (at least to the extent that we have the pre-4.8 behavior).

In a followup PR, I can remove these destructurings/bindings/whatevertheyrecalleds in the declaration emitter.

Note that the new errors added in #41044 remain. I guess the PR had two somewhat-related changes in it?

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Sep 14, 2022
@jakebailey
Copy link
Member Author

@typescript-bot cherry-pick this to release-4.8

Technically, this depends on #50538 but I'm curious to see if it'll work. Probably not.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 15, 2022

Heya @jakebailey, I've started to run the task to cherry-pick this into release-4.8 on this PR at ba4a466. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @jakebailey, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.8 manually.

@andrewbranch
Copy link
Member

@typescript-bot cherry-pick this to release-4.8

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 22, 2022

Heya @andrewbranch, I've started to run the task to cherry-pick this into release-4.8 on this PR at ba4a466. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @andrewbranch, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.8 manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate identifier in function declaration due to stripped property renames
4 participants