-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Partially revert #41044, restoring parameter destructurings in d.ts files #50779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@typescript-bot cherry-pick this to release-4.8 Technically, this depends on #50538 but I'm curious to see if it'll work. Probably not. |
Heya @jakebailey, I've started to run the task to cherry-pick this into |
Hey @jakebailey, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.8 manually. |
@typescript-bot cherry-pick this to release-4.8 |
Heya @andrewbranch, I've started to run the task to cherry-pick this into |
Hey @andrewbranch, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.8 manually. |
Fixes #50707 (at least to the extent that we have the pre-4.8 behavior).
In a followup PR, I can remove these destructurings/bindings/whatevertheyrecalleds in the declaration emitter.
Note that the new errors added in #41044 remain. I guess the PR had two somewhat-related changes in it?