Allow getter and setter types to be unrelated #53417
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43662
The one thing to note/discuss here is that to create unrelated accessors, both the getter and setter must have explicit annotations, because the setter’s type annotation will be used for an unannotated getter return type:
I think this is probably better than making it too easy to accidentally create unrelated accessor types, but perhaps it’s not obvious from the error message that unrelated accessor types are possible.