Skip to content

Commit 23e8e60

Browse files
[Courtesy push] Handle cases when package name has capitalized letters (#20075)
- Added logic to handle cases when package name has capitalized letters and the nuget package has lowercase name.
1 parent bfcd4b2 commit 23e8e60

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

ci/courtesy-push/courtesy-push.js

+9-7
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,11 @@ async function getDeps(depArr) {
6767
for (let i = 0; i < depArr.length; i++) {
6868
const newDep = depArr[i];
6969
var [ name, version ] = await extractDependency(newDep);
70+
const lowercasedName = name.toLowerCase();
7071

71-
if (!deps.hasOwnProperty(name)) deps[name] = {};
72+
if (!deps.hasOwnProperty(lowercasedName)) deps[lowercasedName] = {};
7273

73-
const dep = deps[name];
74+
const dep = deps[lowercasedName];
7475

7576
dep.name = name;
7677
dep.version = version;
@@ -154,17 +155,18 @@ async function updateConfigsForTasks(depsArray, depsForUpdate, updatedDeps) {
154155
while (index < newDepsArr.length) {
155156
const currentDep = newDepsArr[index];
156157
const [ name ] = await extractDependency(currentDep);
157-
158-
if (!name || !basicDepsForUpdate.has(name)) {
158+
159+
const lowerName = name && name.toLowerCase();
160+
if (!name || !basicDepsForUpdate.has(lowerName)) {
159161
index++;
160162
continue;
161163
}
162164

163-
newDepsArr.splice(index, 1, depsForUpdate[name].depStr);
165+
newDepsArr.splice(index, 1, depsForUpdate[lowerName].depStr);
164166
index++;
165167

166-
if (depsForUpdate[name].configs) {
167-
depsForUpdate[name].configs
168+
if (depsForUpdate[lowerName].configs) {
169+
depsForUpdate[lowerName].configs
168170
.sort((a, b) => a.name > b.name)
169171
.forEach(config => {
170172
updatedDepsObj.added.push(config.name);

0 commit comments

Comments
 (0)