Skip to content

Commit d7e1bda

Browse files
fix npmauthenticate v0 setsecret multi line bug (#20086)
1 parent d940afa commit d7e1bda

21 files changed

+3364
-942
lines changed

Tasks/NpmAuthenticateV0/_buildConfigs/Node20/package-lock.json

+950-222
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Tasks/NpmAuthenticateV0/_buildConfigs/Node20/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@
1717
},
1818
"homepage": "https://github.com/Microsoft/azure-pipelines-tasks#readme",
1919
"dependencies": {
20-
"azure-pipelines-task-lib": "^4.1.0",
21-
"azure-pipelines-tasks-packaging-common-v3": "^3.206.0",
20+
"azure-pipelines-task-lib": "^4.13.0",
21+
"azure-pipelines-tasks-packaging-common": "3.241.1",
2222
"@types/mocha": "^5.2.7",
2323
"@types/node": "^20.3.1",
2424
"@types/uuid": "^8.3.0"

Tasks/NpmAuthenticateV0/npmauth.ts

+5-7
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ import * as tl from 'azure-pipelines-task-lib/task';
33
import * as URL from 'url';
44
import * as fs from 'fs';
55
import * as constants from './constants';
6-
import * as npmregistry from 'azure-pipelines-tasks-packaging-common-v3/npm/npmregistry';
7-
import * as util from 'azure-pipelines-tasks-packaging-common-v3/util';
8-
import * as npmutil from 'azure-pipelines-tasks-packaging-common-v3/npm/npmutil';
6+
import * as npmregistry from 'azure-pipelines-tasks-packaging-common/npm/npmregistry';
7+
import * as util from 'azure-pipelines-tasks-packaging-common/util';
8+
import * as npmutil from 'azure-pipelines-tasks-packaging-common/npm/npmutil';
99
import * as os from 'os';
10-
import * as npmrcparser from 'azure-pipelines-tasks-packaging-common-v3/npm/npmrcparser';
11-
import * as pkgLocationUtils from 'azure-pipelines-tasks-packaging-common-v3/locationUtilities';
10+
import * as npmrcparser from 'azure-pipelines-tasks-packaging-common/npm/npmrcparser';
11+
import * as pkgLocationUtils from 'azure-pipelines-tasks-packaging-common/locationUtilities';
1212

1313
async function main(): Promise<void> {
1414
tl.setResourcePath(path.join(__dirname, 'task.json'));
@@ -89,7 +89,6 @@ async function main(): Promise<void> {
8989
let serviceURL = URL.parse(serviceEndpoint.url);
9090
console.log(tl.loc("AddingEndpointCredentials", registryURL.host));
9191
registry = serviceEndpoint;
92-
tl.setSecret(registry.auth);
9392
addedRegistry.push(serviceURL);
9493
npmrcFile = clearFileOfReferences(npmrc, npmrcFile, serviceURL, addedRegistry);
9594
break;
@@ -102,7 +101,6 @@ async function main(): Promise<void> {
102101
let localURL = URL.parse(localRegistry.url);
103102
console.log(tl.loc("AddingLocalCredentials"));
104103
registry = localRegistry;
105-
tl.setSecret(registry.auth);
106104
addedRegistry.push(localURL);
107105
npmrcFile = clearFileOfReferences(npmrc, npmrcFile, localURL, addedRegistry);
108106
break;

Tasks/NpmAuthenticateV0/npmauthcleanup.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import * as util from 'azure-pipelines-tasks-packaging-common-v3/util';
1+
import * as util from 'azure-pipelines-tasks-packaging-common/util';
22
import * as constants from './constants';
33
import * as tl from 'azure-pipelines-task-lib/task';
44
import * as fs from 'fs';

0 commit comments

Comments
 (0)