Skip to content

Commit fc04f86

Browse files
authored
add property to restrict approver from approving their own run (#20593)
1 parent 2b2d81c commit fc04f86

File tree

4 files changed

+1181
-2252
lines changed

4 files changed

+1181
-2252
lines changed

Tasks/ManualValidationV1/Strings/resources.resjson/en-US/resources.resjson

+2
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
"loc.input.help.notifyUsers": "Send a manual validation pending email to specific users (or groups). Only users specified in approvers can act on a manual validation.",
88
"loc.input.label.approvers": "Approvers",
99
"loc.input.help.approvers": "Specify users/groups/project teams separated by commas to act on a manual validation. In absence of input, users with queue build permission will be able to take action.",
10+
"loc.input.label.allowApproversToApproveTheirOwnRuns": "Allow approvers to approve their own run",
11+
"loc.input.help.allowApproversToApproveTheirOwnRuns": "If this is true, approver will be able to approve their own run",
1012
"loc.input.label.instructions": "Instructions",
1113
"loc.input.help.instructions": "These instructions will be shown to the user for resuming or rejecting the manual validation. Based on these instructions the user will take an informed decision about this manual validation.",
1214
"loc.input.label.onTimeout": "On timeout",

Tasks/ManualValidationV1/task.json

+9-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
],
1616
"version": {
1717
"Major": 1,
18-
"Minor": 244,
18+
"Minor": 248,
1919
"Patch": 0
2020
},
2121
"inputs": [
@@ -35,6 +35,14 @@
3535
"required": false,
3636
"helpMarkDown": "Specify users/groups/project teams separated by commas to act on a manual validation. In absence of input, users with queue build permission will be able to take action."
3737
},
38+
{
39+
"name": "allowApproversToApproveTheirOwnRuns",
40+
"type": "boolean",
41+
"label": "Allow approvers to approve their own run",
42+
"required": false,
43+
"defaultValue": "false",
44+
"helpMarkDown": "If this is true, approver will be able to approve their own run"
45+
},
3846
{
3947
"name": "instructions",
4048
"type": "multiLine",

Tasks/ManualValidationV1/task.loc.json

+9-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
],
1616
"version": {
1717
"Major": 1,
18-
"Minor": 244,
18+
"Minor": 248,
1919
"Patch": 0
2020
},
2121
"inputs": [
@@ -35,6 +35,14 @@
3535
"required": false,
3636
"helpMarkDown": "ms-resource:loc.input.help.approvers"
3737
},
38+
{
39+
"name": "allowApproversToApproveTheirOwnRuns",
40+
"type": "boolean",
41+
"label": "ms-resource:loc.input.label.allowApproversToApproveTheirOwnRuns",
42+
"required": false,
43+
"defaultValue": "false",
44+
"helpMarkDown": "ms-resource:loc.input.help.allowApproversToApproveTheirOwnRuns"
45+
},
3846
{
3947
"name": "instructions",
4048
"type": "multiLine",

0 commit comments

Comments
 (0)