Skip to content

Add property to restrict approver from approving their own run #20593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

v-gayatrij
Copy link
Contributor

Task name: ManualValidationV1

Description: Adding new property allowApproversToApproveTheirOwnRuns: boolean to restrict any approver from approving their own run

Documentation changes required: (Y/N) Y

Added unit tests: (Y/N) N

Attached related issue: (Y/N)

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@v-gayatrij v-gayatrij marked this pull request as ready for review November 1, 2024 06:43
@v-gayatrij v-gayatrij requested review from manolerazvan and a team as code owners November 1, 2024 06:43
@z00sts
Copy link
Contributor

z00sts commented Nov 1, 2024

Added unit tests: (Y/N)

Since we're trying to eliminate task regressions by increasing autotest coverage - is it possible to add unit test for that case?

@z00sts z00sts self-requested a review November 1, 2024 09:30
@v-gayatrij
Copy link
Contributor Author

Added unit tests: (Y/N)

Since we're trying to eliminate task regressions by increasing autotest coverage - is it possible to add unit test for that case?

Added units tests along with ADO PR

@v-gayatrij v-gayatrij merged commit fc04f86 into master Nov 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants