-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Break deprecated tasks DownloadPackageV0, NuGetInstallerV0, NuGetRestoreV1 #19325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenghao104
reviewed
Nov 28, 2023
magleaso
previously requested changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error messages should be more direct, should use loc strings whenever possible, and consider whether throwing at the end of the execution of the task is the best way
Tasks/DownloadPackageV0/Strings/resources.resjson/en-US/resources.resjson
Outdated
Show resolved
Hide resolved
Tasks/NuGetInstallerV0/Strings/resources.resjson/en-US/resources.resjson
Outdated
Show resolved
Hide resolved
Tasks/NuGetRestoreV1/Strings/resources.resjson/en-US/resources.resjson
Outdated
Show resolved
Hide resolved
2 tasks
…b.com/microsoft/azure-pipelines-tasks into users/abpowell/break-deprecated-tasks
…b.com/microsoft/azure-pipelines-tasks into users/abpowell/break-deprecated-tasks
Made strings clearer, using loc strings, and had a meeting about breaking at the end vs. beginning
kirill-ivlev
approved these changes
Dec 12, 2023
merlynomsft
reviewed
Dec 12, 2023
merlynomsft
reviewed
Dec 12, 2023
merlynomsft
reviewed
Dec 12, 2023
merlynomsft
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: DownloadPackageV0, NuGetInstallerV0, NuGetRestoreV1
Description: Breaking tests after they complete to make it clear that they are deprecated
Documentation changes required: (Y/N) Y
Added unit tests: (Y/N) Y
Attached related issue: (Y/N) Y - User stories 1662927 and 2075334
Checklist: