Authentication issue fix in AzurePowerShell task #19521
Conversation
| @@ -11,6 +11,9 @@ function convertToNullIfUndefined<T>(arg: T): T|null { | |||
| return arg ? arg : null; | |||
| } | |||
|
|
|||
| let input_workingDirectory = tl.getPathInput('workingDirectory', /*required*/ true, /*check*/ true); | |||
There was a problem hiding this comment.
Could you please move this inside the run function? It is not needed in the global scope. You can then remove second initialization of input_workingDirectory on line 41.
There was a problem hiding this comment.
Done as suggested
There was a problem hiding this comment.
Thank you, but could you please do the same with tempDirectory as well?
| } | ||
|
|
||
|
|
||
| function Disconnect-AzureAndClearContext { |
There was a problem hiding this comment.
Why don't you call the existing Disconnect-AzureAndClearContext from utility.ps1?
There was a problem hiding this comment.
We can't use that utility as it was written specific to windows and present on common which is not supportable for linux hence we created a new file.
There was a problem hiding this comment.
But the code you copied out from there is exactly the same. It would be worth to extract it to separate shared ps1 file and use it on both places.
Task name: AzurePowerShellV5
Description: Pipelines were persisting authentication token while using AzurePowerShellV5 task on Microsoft hosted and Self-Hosted agents.
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Attached related issue: DTS [Pipelines Agents Tasks UI]: pipelines are persisting authentication tokens between runs on self-hosted agents
Checklist: