Skip to content

AzurePowershellV5: Az-function output suppression #19694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 2, 2024
Merged

AzurePowershellV5: Az-function output suppression #19694

merged 7 commits into from
Apr 2, 2024

Conversation

mortenlerudjordet
Copy link
Contributor

Task name: AzurePowershellV5

Description: Suppress Az-functions output in line with rest of task code

Documentation changes required: N

Added unit tests: N

Attached related issue: Y : #19672

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@mortenlerudjordet
Copy link
Contributor Author

@LeftTwixWand and @v-mohithgc: I removed the changes to helper function to make approval process easier.
Opened this new PR with only the changes made to AzurePowershellV5-task.

Hopefully this will make for a streamlined approval engagement.

@mortenlerudjordet
Copy link
Contributor Author

@MrNewgarden: Please approve this also, it's the same as #19674 but removed the changes to VstsAzureHelpers_ as this triggered changing version on many other tasks.

@MrNewgarden
Copy link

@manolerazvan please approve the code

Copy link

Commenter does not have sufficient privileges for PR 19694 in repo microsoft/azure-pipelines-tasks

@MrNewgarden
Copy link

MrNewgarden commented Apr 2, 2024

@v-mohithgc @LeftTwixWand please approve

@LeftTwixWand
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@LeftTwixWand
Copy link
Contributor

LeftTwixWand commented Apr 2, 2024

Hey @MrNewgarden thank you for reaching me out.
And @mortenlerudjordet thank you so much for this contribution❤️

I approved the PR, and it can be merged as soon as pipeline is completed.

@LeftTwixWand
Copy link
Contributor

I've added a commit with version bump

@LeftTwixWand
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@mortenlerudjordet
Copy link
Contributor Author

@LeftTwixWand : Thanks, a bit confusing what should be the correct version to use.
As I did set 238 and 0, but then building the task would change it to something else.
Though good to get it sorted by someone who knows.

@LeftTwixWand LeftTwixWand merged commit 472d785 into microsoft:master Apr 2, 2024
11 checks passed
@LeftTwixWand
Copy link
Contributor

Hey @mortenlerudjordet I completely agree, that versioning might be a bit confusing.
The minor version is usually our sprint number from this resource: whatsprintis.it
And patch is incremental.

But now we're moving from NodeJS 10 to NodeJS 20.
And generating pretty much the same code but for different version of Node.
That's why there is a versioning inconsistency.
It might be really tricky if you're doing it for the first time.😅

Anyway, thank you for the contribution.
Tomorrow we would start a new tasks' deployment, and it might take up to 5 days to reach everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants