Replace sync-request with nodejs-file-downloader #19769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced sync-request with nodejs-file-downloader because the package is not supported anymore - Replaced sync methods with async because nodejs-file-downloader and nodejs makes only async requests
|
Looks that after we changed node version from 20.3.1 to 20.11.0, the npm version came with it updated from 9.6.7 to 10.2.4 in pipelines, and then sync-request library not supported any more. |
DmitriiBobreshev
requested review from
manolerazvan,
a team,
carl-tanner,
fadnavistanmay,
b-barthel,
kunalkaroth and
JeyJeyGao
as code owners
manolerazvan
approved these changes
Apr 15, 2024
kirill-ivlev
approved these changes
Apr 15, 2024
max-zaytsev
approved these changes
Apr 15, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: -
Description:
Pipeline with all built tasks run:
Linux: https://dev.azure.com/mseng/PipelineTools/_build/results?buildId=27803107
Macos: https://dev.azure.com/mseng/PipelineTools/_build/results?buildId=27803554
Windows: https://dev.azure.com/mseng/PipelineTools/_build/results?buildId=27803434
Test fails are expected
Documentation changes required: N
Added unit tests: N
Attached related issue: N
Checklist: