-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add --includeLocalPackagesBuildConfig option to make.js + LocalPackages BuildConfig #20463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlynomsft
commented
Sep 25, 2024
…nder specific configs (e..g when a entry is renamed to skip it)
Do not process tasks that don't have any non-default build configs Do not write version map files for tasks that only have defaultbuild and local packages
…icrosoft/azure-pipelines-tasks into dev/merlynop/consolidate3_test
This reverts commit f3bbc62.
DergachevE
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: N/A
Description: No substantial functional changes are applied by default in this PR. This change adds an option to generate a new build configuration (LocalPackage) that consume internal dependencies using file: references in package.json. If enabled, the LocalPackage configuration uses a shared version across tasks which is managed by BuildConfigGen.
Note: using --includeLocalPackagesBuildConfig is dependent on task-lib and tasks-common being present in the repo, which is not included in this PR
Minor updates:
Documentation changes required: Added locakpackages_buildconfig.md
Added unit tests: Tested via output generation. PR checks tested here:
Attached related issue: AB#2121133
Checklist: