-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix: useContextSelector with React 18 #30951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
layershifter
merged 2 commits into
microsoft:master
from
layershifter:fix/context-selector-attemp2
Jun 13, 2024
Merged
fix: useContextSelector with React 18 #30951
layershifter
merged 2 commits into
microsoft:master
from
layershifter:fix/context-selector-attemp2
Jun 13, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 650 | 627 | 5000 | |
Button | mount | 311 | 321 | 5000 | |
Field | mount | 1123 | 1158 | 5000 | |
FluentProvider | mount | 748 | 722 | 5000 | |
FluentProviderWithTheme | mount | 80 | 82 | 10 | |
FluentProviderWithTheme | virtual-rerender | 63 | 64 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 73 | 78 | 10 | |
MakeStyles | mount | 891 | 895 | 50000 | |
Persona | mount | 1774 | 1800 | 5000 | |
SpinButton | mount | 1424 | 1413 | 5000 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
📊 Bundle size reportUnchanged fixtures
|
🕵 fluentuiv9 No visual regressions between this PR and main |
4182e5a
to
85dd57c
Compare
bsunderhus
approved these changes
Jun 12, 2024
ling1726
approved these changes
Jun 13, 2024
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
useContextSelector()
implementation relies on bail-outs if values are shallow equal:fluentui/packages/react-components/react-context-selector/src/useContextSelector.ts
Lines 47 to 49 in 1f3d2e7
However, this does not work anymore with React 18 💥
React 17
React 18
Note 1: useLayoutEffect
This effect propagates updates to its consumers once "Parent" gets rendered:
fluentui/packages/react-components/react-context-selector/src/createContext.ts
Lines 25 to 34 in 1f3d2e7
This results in performance degradation during the initial render 🐌 The change in the behavior was not expected, but it's a part of React 18: facebook/react#22445.
New Behavior
This PR switches
useReducer()
used inuseContextSelector()
touseState()
that still has the behavior with bailout. In the longterm, we should explore the approach of usinguseSyncExternalStore()
for this functionality.