dom0_kernel_installer: Add new menuentry for installed kernel #3894
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a new menuentry for the installed kernel by introducing additional fields into the installer schema and updating the installer method to configure the GRUB settings accordingly.
- Added new fields (additional_grub_file, target_grub_file_path, default_grub_id) to the schema
- Updated the BinaryInstaller.install method to handle GRUB file modifications and configuration based on the Mariner version
- Adjusted file permissions and substituted placeholders in the GRUB file
pupacha
force-pushed
the
pavan/fix_kernel_installer
branch
2 times, most recently
from
dbbfe43 to
d7273c9
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Writes to /boot/grub2/grub.cfg are not permanent and will be overriden when grub-update action is performed. Adding a new entry and making it the default will solve this problem. Introduce additional_grub_file, which acts as a template for the new menuentry with the installed kernel.
pupacha
force-pushed
the
pavan/fix_kernel_installer
branch
from
d7273c9 to
85da1f0
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the dom0 kernel installer to add a new menu entry for the installed kernel, in order to make the kernel upgrade permanent by modifying GRUB configuration. The changes include importing an additional tool (Chmod), adding new schema fields (additional_grub_file, target_grub_file_path, default_grub_id), and extending the install method to handle GRUB file updates differently based on the Mariner version.
| ) | ||
| # Add the new GRUB_DEFAULT line with the new kernel | ||
| node.execute( | ||
| f"sed -i.bak '1i GRUB_DEFAULT={default_grub_id}' {grub_default_file}", |
There was a problem hiding this comment.
can sed tool have the method to do this? if no, can you add the method in the sed tool?
Writes to /boot/grub2/grub.cfg are not permanent and will be overriden when grub-update action is performed. Adding a new entry and making it the default will solve this problem. Introduce additional_grub_file, which acts as a template for the new menuentry with the installed kernel.