Azure : Added unmanaged VHD cleanup while deleting resource group #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamshital
force-pushed
the
vhd_cleanup
branch
4 times, most recently
from
71c4d25 to
f0ecfe1
Compare
|
@iamshital Thanks for implementing this, I have a tested, seems it only delete the VM in the RG. |
|
@iamshital @LiliDeng @lizzha please review and sign off |
|
@juhlee-microsoft , I'm blocked actually for this PR. |
|
A new approach has been implemented. I've done the basic testing. It is working. |
iamshital
force-pushed
the
vhd_cleanup
branch
3 times, most recently
from
05e7d01 to
5e6591f
Compare
|
Removed the DO NOT MERGE. PR is ready to review. |
|
PR is still under test. Will PR review with the result. |
lizzha
suggested changes
Jul 31, 2019
|
|
||
| [void] RunTestCleanup() { | ||
| # Wait till all the cleanup background jobs successfully started cleanup of resource groups. | ||
| $DeleteResourceGroupJobs = Get-Job | Where-Object { $_.Name -imatch "DeleteResourceGroup" } |
There was a problem hiding this comment.
I remember we had a discussion that we don't want to wait for the jobs to complete, to save the execution time.
Can we just leave the jobs running, and don't wait for them to complete?
There was a problem hiding this comment.
@lizzha , Yes I've considered this.
In case of managed disks, there will not be any jobs waiting.
In case of unmanaged disks, We wait till the VMs + Disks are deleted. After that, resource group cleanup starts, and LISAv2 continues...
If we don't wait, then job may get terminated, and VHD's will not be removed.
And, This block of code executes at the end of LISAv2 only.
Till now, I've observed that it may wait upto 2 minutes.
Libraries/Azure.psm1
Outdated
|
|
||
| # Give at least 30 seconds to start all the VM cleanup operations. | ||
| # Timeout is adjusted based on number of VMs. | ||
| $MaxAttempts = 10 + $VMs.Count |
There was a problem hiding this comment.
how long does it usually take to start all the cleanup operations? We don't want it to increase the execution time too much
There was a problem hiding this comment.
It usually takes less than 15 seconds.
|
Works well, segment of log from pipeline segment of log from local |
LiliDeng
reviewed
Aug 1, 2019
iamshital
force-pushed
the
vhd_cleanup
branch
2 times, most recently
from
87f005c to
850d94a
Compare
Scenario 1 - Delete 2 VMs with unmanaged VHDsTotal VM Clenaup time : 15 seconds. (VHD cleanup continues in background after this) Scenario 2 - Delete 32 VMs with unmanaged VHDsTotal VM Clenaup time : 23 seconds. (VHD cleanup continues in background after this) Scenario 3 : Delete VMs with managed disks (No change in execution time) |
LiliDeng
reviewed
Aug 6, 2019
lizzha
approved these changes
Aug 6, 2019
|
In recent change -
|
|
Logs from latest changes - |
|
@juhlee-microsoft @LiliDeng Can you review and approve? |
LiliDeng
approved these changes
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issues of - "Unmanaged VHDs are left behind, after Resource group deletion"
Now, LISAv2 will immediately remove all unmanaged VHDs (OSDisks and DataDisks) immediately without needing to rely on external cleanup job.