TabView gap between active tab and active content fix #6644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
RBrid
reviewed
Feb 2, 2022
ojhad
force-pushed
the
user/ojhad/tabviewcontourfix
branch
from
096e486 to
961f8d2
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ojhad
changed the title
ojhad
force-pushed
the
user/ojhad/tabviewcontourfix
branch
from
961f8d2 to
750a93e
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
RBrid
approved these changes
Feb 28, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| SetFirstTabSelectedBackgroundPathFill(tabBrush); | ||
|
|
||
| var contentBrush = new SolidColorBrush(); | ||
| contentBrush.Color = Colors.Green; |
There was a problem hiding this comment.
should these colors be translucent?
There was a problem hiding this comment.
Or maybe have a button to set translucency to 50%
There was a problem hiding this comment.
I added buttons to set each of these to transparent. Does that cover this use case or was there another use case you are thinking of?
StephenLPeters
approved these changes
Feb 28, 2022
StephenLPeters
added
area-TabView
team-Controls
RBrid
added a commit
that referenced
this pull request
Apr 12, 2022
* Reverting product change made for 'TabView gap between active tab and active content fix #6644' * TabView expansions fix
kmahone
pushed a commit
that referenced
this pull request
May 4, 2022
* Reverting product change made for 'TabView gap between active tab and active content fix #6644' * TabView expansions fix
|
🎉This issue was addressed in #6954, which has now been successfully released as Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gap between active tab and active tab content when device scale factor is not 100%
The
SelectedBackgroundPathpath is not being drawn all the way down in non-100% scale factors. Layout rounding API does not seem to fix this. I added an extra pixel toTabGeometrywhich is being used to draw the background. That fixed the drawing at non-100% scale factors while still looking correct at 100% scale.Motivation and Context
fixes internal bugs 37332027
Screenshots
Pre-Fix on top of Post-Fix
100% scale
125% scale
150% scale
175% scale
200% scale
