CommandBarFlyoutCommandBar fix - respond to size changes #6868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ojhad
added
team-Controls
Closed
2 tasks
ojhad
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just reacting to AppBarButton / AppBarToggleButton dependency property changes that might affect the owning CommandBarFlyout size, react to size changes in general to account for CommandBarFlyoutCommandBar visibility changes (addresses issue #6864) and OverflowContentRoot size changes.
The changes involve expanding the use of the internal parameter 'isForCommandBarElementDependencyPropertyChange' to size changes in general. I thus changed its name to 'isForSizeChange'.
I added a new test for the case where an AppBarButton visibility changes, and a test for the case where the OverflowContentRoot size changes.