use cred to make remote pwsh session #4118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
reviewed
Feb 7, 2024
scripts/secnetperf.ps1
Outdated
| @@ -98,7 +98,14 @@ $useXDP = ($io -eq "xdp" -or $io -eq "qtip") | |||
| # Set up the connection to the peer over remote powershell. | |||
| Write-Host "Connecting to $RemoteName" | |||
| if ($isWindows) { | |||
| $Session = New-PSSession -ComputerName $RemoteName -ConfigurationName PowerShell.7 | |||
| if ($os -eq "windows-2025") { | |||
There was a problem hiding this comment.
Should we simply just always do this? If it works for 2022, I think I'd rather have the simpler script.
There was a problem hiding this comment.
lets try and see if this works for WS 2022
There was a problem hiding this comment.
it looks like it works. Lab failures are unrelated, currently doing some tweaking to diagnose poor performance.
nibanks
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WS2025 exhibits weird behavior when starting remote PWSH sessions. This is a workaround.
Testing
CI
Documentation
N/A